-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support server name signature for private plugins #36355
Comments
Hi @FStefanni - thanks for the contribution. It's a great idea - one we have actually been speaking about recently and are planning to address it soon, starting with a design doc. The examples you provided I would think cover a high percentage of use cases, so that might likely be the first step, but still TBD. |
Hi, great :) I'll wait for this feature in the next releases then. Regards. |
Please see #36228 (comment) |
Hi! Really like this idea (well, actually we need this). We build our Grafana instance with custom (in-house) plugins once and deploy it to different sites, all running in different subdomains: The amount of sites is unknown when building the image (and thus when signing the plugin) so some sort of wildcard support would help us out in this scenario. |
Closing as supported but on per-request basis #50652 (comment) |
Hi.
What would you like to be added:
It would be nice to be able to sign a private plugin once, for a group of grafana instances, related to some server(s) names.
At the moment it is required to add an explicit
--rootUrls
for each installation, which is not suitable in case of many grafana installations. So the suggestion is:root_url
configuration and signature, as long as the signature is the domain. For example, signing forwww.myserver.com
should allow enabling the plugin inwww.myserver.com/grafana1
andwww.myserver.com/other/grafana2
*.myserver.com
: to enable the plugin for each instance of grafana running on any matching sub-domain (e.g.grafana.myserver.com
andsupport.me.myserver.com
)It should suffice to allow to pass
--rootUrls www.myserver.com
or--rootUrls *.myserver.com
to enable the suggested signatures.Why is this needed:
It is required in case of many grafana instances. In my case, we have in production more than 40 grafana instances, on 3 different servers. At the moment, we should sign our private plugin for each single grafana instance, which is not feasible. moreover, we should re-sign it for any new installation (again, it is a huge overhead).
Regards.
The text was updated successfully, but these errors were encountered: