Graph(old): It no longer renders thresholds in 8.1+

[torkelo]

Noticed on play site that the old graph is no longer showing any thresholds.

• Example https://play.grafana.org/d/000000074/alerting?orgId=1&editPanel=4

[hugohaggmark]

Is this related to what you're working on @dprokop, I mean with thresholds?

[dprokop]

Is this related to what you're working on @dprokop, I mean with thresholds?

Nope - my work is related to enabling threshold controls in the graph ng based visualizations, and in the alerting views to start with. We have not decided yet whether or not we want to bring this functionality to the time series panel.

[axelavargas]

@torkelo I noticed there is a message that says: Visual thresholds options disabled, it seems intentional

[axelavargas]

Nevermind, I tested in another dashboard and indeed there are no thresholds, I will take a look :)

[axelavargas]

Update:

I noticed in the graph plugin we have this line that is checking if ng-alert feature toggle is enabled or not, based on that it will draw the thresholds. On play.grafana.org we have that feature toggle enabled, and this is the reason we can't see thresholds.

// unified alerting does not support threshold for graphs, at least for now
if (!config.featureToggles.ngalert) {
      this.thresholdManager = new ThresholdManager(this.ctrl);
 }

Locally I tested removing the feature toggle and the thresholds were shown correctly, I asked the alerting team about this topic, to gather more context.

[torkelo]

@axelavargas ah! please remove that if statement, we should always add the threshold manager

[axelavargas]

@torkelo I got some feedback from @domasx2, this was added to avoid showing dashboard alerts thresholds when ngalert is enabled, but the implementation is missing other threshold use cases like this, he will take over this issue tomorrow.

[torkelo]

@domasx2 not sure I understand the logic for now showing graph thresholds, this display option should be available to users always.

[domasx2]

The intention was to only disable dashboard alert thresholds if ngalert is enabled. Disabling thresholds entirely was a mistake. Not enough research / PR reviews I guess :)

[torkelo]

@domasx2 but even with ngalert enabled, do not understand the reasons to disable a graph visualization feature

[domasx2]

Did not intend to disable graph visualizatiom feature entirely, this was a mistake. Just to not render old existing dashboard alert threshold if ngalert is emabled

[domasx2]

I think didnt realize at the time that threshold manager was not for alerts only, my bad

[domasx2]

@hugohaggmark @torkelo need some input on how to best proceed with fixing this, problem descirbed in draft PR: #38918 🙇