Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotation editor api: improve datasource support #53883

Open
gabor opened this issue Aug 18, 2022 · 3 comments
Open

annotation editor api: improve datasource support #53883

gabor opened this issue Aug 18, 2022 · 3 comments

Comments

@gabor
Copy link
Contributor

gabor commented Aug 18, 2022

when the angular-removal from datasources happened, certain shortcuts had to be added to the code, because the "after angular" annotation API cannot currently support certain datasources, like prometheus, so code like this was added: https://github.com/grafana/grafana/blob/main/public/app/features/annotations/standardAnnotationSupport.ts#L231-L260

the situation should be improved so that such identify-datasource-by-name checks are not needed.

@gabor gabor changed the title annotation editor api: improve "after angular" situation annotation editor api: improve datasource support Aug 18, 2022
Copy link
Contributor

This issue has been automatically marked as stale because it has not had activity in the last year. It will be closed in 30 days if no further activity occurs. Please feel free to leave a comment if you believe the issue is still relevant. Thank you for your contributions!

@github-actions github-actions bot added the stale Issue with no recent activity label Jan 14, 2024
@gabor
Copy link
Contributor Author

gabor commented Jan 15, 2024

(seems thsi never got assigned to a squad, so i assigned it manually to frontend-platform)

@github-actions github-actions bot removed the stale Issue with no recent activity label Jan 16, 2024
@JoaoSilvaGrafana
Copy link
Contributor

Annotations are part of dashboards squad, I have opened a PR to change the codeowners to reflect that and will move this issue to that squad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🗂️ Needs Triage / Escalation
Development

No branches or pull requests

4 participants