Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata information #58377

Closed
Tracked by #169
cyriltovena opened this issue Aug 26, 2022 · 3 comments · Fixed by #61921
Closed
Tracked by #169

Metadata information #58377

cyriltovena opened this issue Aug 26, 2022 · 3 comments · Fixed by #61921
Assignees
Labels
area/panel/flame-graph prio/medium Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@cyriltovena
Copy link
Contributor

cyriltovena commented Aug 26, 2022

The flamegraph panel should contains information at the top such as:

  • The type of samples and what it represents. (This is the highest priority)
  • The total amount of profiles in the range.
  • The max/min node in sample type e.g seconds, bytes, count,...
@cyriltovena cyriltovena changed the title Metadata informations ( type of samples, total amount of profiles across how many series, etc....) Metadata informations Aug 26, 2022
@cyriltovena cyriltovena changed the title Metadata informations Metadata information Aug 26, 2022
@simonswine
Copy link
Contributor

simonswine commented Aug 30, 2022

@cyriltovena (will provide a screenshot and more context) screenshot would be helpful how to format the information and a source of the information.

@aocenas
Copy link
Member

aocenas commented Oct 5, 2022

I assume this should be driven by some API like https://prometheus.io/docs/prometheus/latest/querying/api/#querying-metric-metadata or bake it into the list of profile types right?

@cyriltovena
Copy link
Contributor Author

Yes we should add it to the profile types. I think this is not required anymore for 0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/panel/flame-graph prio/medium Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants