Dashboard: Add value format for requests per minute #62258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwradcliffe
requested review from
joshhunt,
yaelleC,
leventebalogh,
codeincarnate and
oscarkilhed
and removed request for
a team
|
|
dwradcliffe
requested review from
axelavargas and
polibb
and removed request for
a team
polibb
approved these changes
Feb 17, 2023
|
Hi @dwradcliffe 🙌. We are ready to merge this PR, but there's some checks failing - main concern is the one detecting breaking changes. |
|
This pull request was removed from the 9.4.3 milestone because 9.4.3 is currently being released. |
|
@dwradcliffe pinging you to request a response 👋. |
polibb
added
stale
dwradcliffe
force-pushed
the
requests_per_minute
branch
from
c6fdfed
to
e929dbf
Compare
|
Sorry for the delay; rebased on main. |
|
This pull request was removed from the 9.4.5 milestone because 9.4.5 is currently being released. |
dwradcliffe
force-pushed
the
requests_per_minute
branch
from
e929dbf
to
0595e99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Add value format for throughput: requests per minute (rpm).
Why do we need this feature?
We have a lot of graphs that use
rpminstead ofrps. This allows us to use the right formatting.Who is this feature for?
Anyone building dashboards.
Which issue(s) does this PR fix?:
N/A