Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Fix goimports grouping #62427

Merged
merged 2 commits into from Jan 30, 2023
Merged

Chore: Fix goimports grouping #62427

merged 2 commits into from Jan 30, 2023

Conversation

zserge
Copy link
Contributor

@zserge zserge commented Jan 28, 2023

This PR deprecates #60870 and fixes goimports ordering in Observability Metrics packages

@zserge zserge added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Jan 28, 2023
@zserge zserge added this to the 9.5.0 milestone Jan 28, 2023
@ying-jeanne ying-jeanne mentioned this pull request Jan 30, 2023
Closed
@zserge zserge marked this pull request as ready for review January 30, 2023 08:36
@zserge zserge requested a review from a team as a code owner January 30, 2023 08:36
@zserge zserge merged commit f8ec35e into main Jan 30, 2023
@zserge zserge deleted the zserge/goimports-observability-metrics branch January 30, 2023 08:38
@zerok zerok modified the milestones: 9.5.0, 9.4.0 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idafurjes idafurjes idafurjes approved these changes

Assignees
No one assigned
Labels
area/backend datasource/Graphite datasource/Prometheus enterprise-ok no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Milestone
9.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zserge @idafurjes @zerok @grafanabot