Alerting: Better printing of labels #63348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is based off #63347. |
yuri-tceretian
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
LGTM!
It is worth mentioning that this is used only in expanding templates in the rule's labels and annotations. Therefore, this should not have a negative effect on the notifications sent by the alertmanager. The positive effect, though, is that it will make templates like
{ $values.B.labels } to be much more readable, which is a significant improvement!
This commit changes how labels are printed in templates for custom annotations and labels from map[foo:bar bar:baz] to foo=bar, bar=baz. Labels are comma separated, and sorted in increasing order.
grobinson-grafana
force-pushed
the
grobinson/better-print-labels
branch
from
5d931a5
to
49fc3e3
Compare
ryantxu
pushed a commit
that referenced
this pull request
Mar 2, 2023
This commit changes how labels are printed in templates for custom annotations and labels from map[foo:bar bar:baz] to foo=bar, bar=baz. Labels are comma separated, and sorted in increasing order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This pull request changes how labels are printed in templates for custom annotations and labels from
map[foo:bar bar:baz]tofoo=bar, bar=baz. Labels are comma separated, and sorted in increasing order.Why do we need this feature?
[Add a description of the problem the feature is trying to solve.]
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Fixes #63349
Special notes for your reviewer: