Elasticsearch: Improve query type selection #63402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backend code coverage report for PR #63402 |
|
Frontend code coverage report for PR #63402
|
gabor
force-pushed
the
gabor/elastic-better-ui
branch
from
7f2dd3a
to
3dbe646
Compare
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
grafanabot
added
stale
|
keep it open please |
gabor
force-pushed
the
gabor/elastic-better-ui
branch
from
3dbe646
to
c8860c5
Compare
|
You have successfully added a new CodeQL configuration |
gabor
force-pushed
the
gabor/elastic-better-ui
branch
2 times, most recently
from
f1deb97
to
53b9d0a
Compare
gabor
force-pushed
the
gabor/elastic-better-ui
branch
3 times, most recently
from
096e43f
to
866ddec
Compare
gabor
force-pushed
the
gabor/elastic-better-ui
branch
from
866ddec
to
b52b498
Compare
gabor
changed the title
ivanahuckova
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
( fixes #62216 )
in the elasticsearch query editor, currently, when you want to run a logs-query or a raw-data-query or a raw-document-query, you choose it by finding the right option in the "metric" select-box. this is hard to discover.
this pull request moves the 4 query types (metric, logs, raw-data, raw-doc) to the top of the query editor. and makes sure the logs, raw-data and raw-doc options do not show up in the metric-list anymore.
please note, this is purely a visual change, the underlying
ElasticQuerydata model does not change.additional changes:
querytolucene query, and adjusted the text-field placeholder-textfuture work: to decide which metric-options to hide we use the already existing
isSingleMetricboolean. it already exists, because the reducers needed to know that when one of these (logs, raw-data, raw-doc) is chosen, all existing bucket-aggregations should be removed in the user-interface. i think we should rename it to something more descriptive, perhapsisSpecialMetric(naming ideas very welcome 👍 )... but did not want to make the PR more complex, so will do in a separate PR later.how to test: