Loki: Improve the display of loki query stats #63623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grafana/observability-logs functionality works as expected just need to fix some tests, can still be reviewed. |
|
Backend code coverage report for PR #63623 |
|
Frontend code coverage report for PR #63623
|
public/app/plugins/datasource/loki/components/monaco-query-field/MonacoQueryField.tsx
Outdated
Show resolved
Hide resolved
public/app/plugins/datasource/loki/components/monaco-query-field/MonacoQueryField.tsx
Outdated
Show resolved
Hide resolved
public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderOptions.tsx
Outdated
Show resolved
Hide resolved
public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderOptions.tsx
Outdated
Show resolved
Hide resolved
public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderOptions.tsx
Outdated
Show resolved
Hide resolved
svennergr
reviewed
Feb 28, 2023
public/app/plugins/datasource/loki/components/monaco-query-field/MonacoQueryField.tsx
Outdated
Show resolved
Hide resolved
ivanahuckova
reviewed
Mar 3, 2023
public/app/plugins/datasource/loki/components/monaco-query-field/MonacoQueryField.tsx
Outdated
Show resolved
Hide resolved
public/app/plugins/datasource/loki/components/monaco-query-field/MonacoQueryField.tsx
Outdated
Show resolved
Hide resolved
public/app/plugins/datasource/loki/components/LokiQueryField.tsx
Outdated
Show resolved
Hide resolved
public/app/plugins/datasource/loki/querybuilder/components/LokiQueryBuilderOptions.tsx
Outdated
Show resolved
Hide resolved
matyax
reviewed
Mar 6, 2023
public/app/plugins/datasource/loki/components/AnnotationsQueryEditor.tsx
Outdated
Show resolved
Hide resolved
matyax
reviewed
Mar 6, 2023
matyax
requested changes
Mar 6, 2023
|
I think we might want to prioritize this task, given the upcoming delivery dates. Edit: with "delivery date" I mean query splitting. We may want to have this ready to ship along with that. |
matyax
reviewed
Mar 6, 2023
public/app/plugins/datasource/loki/components/monaco-query-field/MonacoQueryField.tsx
Outdated
Show resolved
Hide resolved
svennergr
reviewed
Mar 14, 2023
svennergr
reviewed
Mar 14, 2023
public/app/plugins/datasource/loki/querybuilder/components/LokiQueryCodeEditor.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
builder/coderefresh stats on timerange change.coderefresh stats on type.Why do we need this feature?
fixed some bugs and updates stats on type
Who is this feature for?
...
Which issue(s) does this PR fix?:
Fixes #63343
Special notes for your reviewer:
to test
refresh stats on timerange change, create a query in builder or code then edit the timerange and you should see the stats update.to test
refresh stats on type, create a query in the code editor, if the query is valid the stats will update after 1 second of no typing.