Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Legacy Graph Panel] Auto migrate to Timeseries #63732

Open
Tracked by #49670
yaelleC opened this issue Feb 24, 2023 · 12 comments
Open
Tracked by #49670

[Legacy Graph Panel] Auto migrate to Timeseries #63732

yaelleC opened this issue Feb 24, 2023 · 12 comments
Labels
area/panel/graph area/panel/timeseries The main time series Graph panel

Comments

@yaelleC
Copy link
Contributor

yaelleC commented Feb 24, 2023

To fully deprecate Angular, we need to get rid of the Legacy Graph Panel (currently missing time regions feature)

In its current state the user is prompted to trigger the migration manually. We would like to auto migrate the legacy graph panel to timeseries.

@grafanabot
Copy link
Contributor

@yaelleC please add one or more appropriate labels. Here are some tips:

  • if you are making an issue, TODO, or reminder for yourself or your team, please add one label that best describes the product or feature area. Please also add the issue to your project board. 🚀

  • if you are making an issue for any other reason (docs typo, you found a bug, etc), please add at least one label that best describes the product or feature that you are discussing (e.g. area/alerting, datasource/loki, type/docs, type/bug, etc). Our issue triage doc also provides additional guidance on labeling. 🚀

Thank you! ❤️

@grafanabot grafanabot added the internal for issues made by grafanistas label Feb 24, 2023
@yaelleC yaelleC added area/panel/graph and removed internal for issues made by grafanistas labels Feb 24, 2023
@yaelleC yaelleC added this to the 10.0.0 milestone Feb 24, 2023
@justinsmalley
Copy link

If the x-axis mode is set to histogram, this should migrate to the new Histogram panel instead of timeseries. One thing to note is that new histogram panel has an option for "Bucket Size", while the graph panel histogram has an option for "Number of Buckets". Bucket size can only be calculated if there is a suitable max and min size set, so there is still somewhat of a gap. Speaking of min and max, there is an outstanding issue #62273 where that does not yet work for histograms. This issue is preventing me from migrating in advance.

@samjewell
Copy link
Contributor

Are we planning to complete #49670 before we make this change? We still have some gaps in that checklist on that Epic.

@leeoniya
Copy link
Contributor

leeoniya commented Apr 17, 2023

there are two hi-pri work items there. (hide zeros/nulls, time regions). the former is done but still needs migration code, the latter will land by G10. i think the rest can wait.

in any case, we'll need to do a gradual rollout of this auto migration and wait for bugs/feedback at each stage.

@dmitriishaburov
Copy link

Is there any timeline for that?
We have Grafanas with multiple thousands of Graph panels, and performing manual migration one-by-one is impossible.
Currently I'd need to create migration script by my own, but since there's existing feature in Grafana it seems strange.

@ac-i-kis
Copy link

Is there any timeline for that? We have Grafanas with multiple thousands of Graph panels, and performing manual migration one-by-one is impossible. Currently I'd need to create migration script by my own, but since there's existing feature in Grafana it seems strange.

same here

@jmorcar
Copy link

jmorcar commented May 7, 2024

Is there any timeline for that? We have Grafanas with multiple thousands of Graph panels, and performing manual migration one-by-one is impossible. Currently I'd need to create migration script by my own, but since there's existing feature in Grafana it seems strange.

+1

@leeoniya
Copy link
Contributor

leeoniya commented May 7, 2024

they will be auto-migrated, but we encourage people to at least supervise some migrations manually to find and report any migration bugs so we can fix them prior to enabling auto-migration once the old Graph code is actually removed from the codebase (G12).

@dmitriishaburov
Copy link

@leeoniya what I've heard about Grafana 11 preview "auto" migration would still require to open every single dashboard in UI and re-save it, which would take some time in case of 1.5k dashboards 😢

@hconnan
Copy link

hconnan commented May 22, 2024

We have in the same situation as @dmitriishaburov. Do you have any timeline for this guys?

@jmorcar
Copy link

jmorcar commented Jun 7, 2024

I notice an issue when apply auto migration dashboard that contains --> type: "table-old" . Auto migration feature not working on these cases. I always have to edit JSON format of dash and replace manually "table-old" by "table". Tested in image ----> grafana/grafana:11.0.0

@khushbooag4
Copy link

Is there any timeline for that? We have Grafanas with multiple thousands of Graph panels, and performing manual migration one-by-one is impossible. Currently I'd need to create migration script by my own, but since there's existing feature in Grafana it seems strange.

+1, any update on this. @jmorcar @dmitriishaburov - How a migration script will be created, if we want to upgrade grafana from 8 to 10 having a lot of dashboards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/panel/graph area/panel/timeseries The main time series Graph panel
Projects
None yet
Development

No branches or pull requests