Datasources: Add user_agent header customization for outgoing HTTP requests #63769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhichli
requested review from
marefr,
andresmgot,
asimpson,
bossinc,
mildwonkey,
yangkb09 and
ying-jeanne
and removed request for
a team
grafanabot
added
type/docs
area/backend
datasource/Azure
chri2547
reviewed
Feb 27, 2023
| @@ -484,6 +484,10 @@ Limits the amount of bytes that will be read/accepted from responses of outgoing | |||
|
|
|||
| Limits the number of rows that Grafana will process from SQL (relational) data sources. Default is `1000000`. | |||
|
|
|||
| ### user_agent | |||
|
|
|||
| Sets a custom value for `User-Agent` header for outgoing data proxy requests. If empty, default value will be `Grafana/<BuildVersion>` (e.g. `Grafana/9.0.0`). | |||
There was a problem hiding this comment.
Suggested change
| Sets a custom value for `User-Agent` header for outgoing data proxy requests. If empty, default value will be `Grafana/<BuildVersion>` (e.g. `Grafana/9.0.0`). | |
| Sets a custom value for the `User-Agent` header for outgoing data proxy requests. If empty, the default value is `Grafana/<BuildVersion>` (for example `Grafana/9.0.0`). |
There was a problem hiding this comment.
Thanks for the suggestion! Addressed.
chri2547
reviewed
Feb 27, 2023
marefr
requested changes
Feb 28, 2023
| @@ -243,7 +242,6 @@ func (e *AzureResourceGraphDatasource) createRequest(ctx context.Context, logger | |||
| } | |||
| req.URL.Path = "/" | |||
| req.Header.Set("Content-Type", "application/json") | |||
| req.Header.Set("User-Agent", fmt.Sprintf("Grafana/%s", setting.BuildVersion)) | |||
There was a problem hiding this comment.
You seem to have a failed test due to this change
zhichli
changed the title
marefr
changed the title
|
Thank you for contributing to Grafana |
ryantxu
pushed a commit
that referenced
this pull request
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #63767 based on comment in the original discussion #58714