Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformations: Support time format when converting time to strings #63826

Merged
merged 5 commits into from Mar 2, 2023

Conversation

ryantxu
Copy link
Member

@ryantxu ryantxu commented Feb 28, 2023

Currently when using transformers to convert a time to string, we render the unix milliseconds as a string -- this is less helpful than people would like :)

This PR uses the 'dateFormat' option to format times when converting from a time field.

image

See also #63828 and #63827 for an improved UX

@ryantxu ryantxu marked this pull request as ready for review March 1, 2023 15:43
@ryantxu ryantxu requested review from a team as code owners March 1, 2023 15:43
@ryantxu ryantxu requested review from tskarhed, yaelleC and academo and removed request for a team March 1, 2023 15:43
@ryantxu ryantxu changed the title WIP/Transformations: Support time format when converting time to strings Transformations: Support time format when converting time to strings Mar 1, 2023
@ryantxu ryantxu requested a review from leeoniya March 2, 2023 02:01
@ryantxu ryantxu merged commit a4fc8b9 into main Mar 2, 2023
@ryantxu ryantxu deleted the convert-xform-update branch March 2, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants