Alerting: Add fuzzy search to alert list view #63931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konrad147
added
area/alerting
konrad147
changed the title
| @@ -2693,9 +2693,6 @@ exports[`better eslint`] = { | |||
| "public/app/features/alerting/unified/components/rules/RuleDetailsDataSources.tsx:5381": [ | |||
| [0, 0, 0, "Do not use any type assertions.", "0"] | |||
| ], | |||
| "public/app/features/alerting/unified/components/rules/RulesFilter.tsx:5381": [ | |||
public/app/features/alerting/unified/components/rules/RulesFilter.tsx
Outdated
Show resolved
Hide resolved
gillesdemey
reviewed
Mar 1, 2023
public/app/features/alerting/unified/components/rules/RulesFilter.tsx
Outdated
Show resolved
Hide resolved
public/app/features/alerting/unified/components/rules/RulesFilter.tsx
Outdated
Show resolved
Hide resolved
| @@ -76,37 +77,64 @@ export const useFilteredRules = (namespaces: CombinedRuleNamespace[], filterStat | |||
| return useMemo(() => filterRules(namespaces, filterState), [namespaces, filterState]); | |||
| }; | |||
|
|
|||
| const ufuzzy = new uFuzzy({ | |||
There was a problem hiding this comment.
nit: Can we add a link to the ufuzzy docs here so we can find out what these params mean?
There was a problem hiding this comment.
or just note that they're effectively Damerau–Levenshtein distance allowances for each term/word in the needle. (typo tolerance)
There was a problem hiding this comment.
Yea I kinda guessed as much (though I'm not familiar with the Damerau variant) :)
There was a problem hiding this comment.
I'm not familiar with the Damerau variant
it just treats adjacent transpositions as an edit distance of 1 instead of 2 (removal + insertion). now you're familiar with it 🤣
but i'll tell you a secret: uFuzzy just constructs a regex with all the variations 🐵. since building actual M x N string distance tables in JS for every item would be 🐢 🐌 🦥
leeoniya
reviewed
Mar 1, 2023
| @@ -26,32 +26,37 @@ beforeAll(() => { | |||
| }); | |||
|
|
|||
| describe('filterRules', function () { | |||
| it('should filter out rules by name filter', function () { | |||
| // Typos there are deliberate to test the fuzzy search | |||
| it.each(['cpu', 'hi usage', 'usge'])('should filter out rules by name filter = "%s"', function (nameFilter) { | |||
gillesdemey
approved these changes
Mar 2, 2023
…-alert-rules-fuzzy-search
…-alert-rules-fuzzy-search
eleijonmarck
pushed a commit
that referenced
this pull request
Mar 13, 2023
* Add basic fuzzy search * Add fuzzy search to rule name, group and namespace filters * Add tests * Apply sort order when filtering * Filter rules on Enter instead of onChange * Add minor rule stats performance improvements * Fix tests * Remove unused code, add ufuzzy inline docs * Use form submit to set query string, add debounce docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This feature adds fuzzy search to the alert list view search
Entities capable of being fuzzy searched:
Additionally changes the search behavior to only apply on
enterinstead of debouncing on input.Why do we need this feature?
We want to allow users to make typos and non-full names when searching
Who is this feature for?
Alerting users
Which issue(s) does this PR fix?:
Fixes #62587
Search in multiple words
Typos
