New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PublicDashboards: Paused or deleted public dashboard screen #63970
Conversation
might be helpful to keep this PR and the enterprise one named the same |
The only thing I noticed while testing it was if I use the light theme on my Grafana instance, the paused page still uses the dark theme. Not sure if this matters. I think the request access page does the same thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Page looks good 👍
@@ -20,4 +20,6 @@ var ( | |||
ErrInvalidMaxDataPoints = errutil.NewBase(errutil.StatusBadRequest, "publicdashboards.maxDataPoints", errutil.WithPublicMessage("maxDataPoints should be greater than 0")) | |||
ErrInvalidTimeRange = errutil.NewBase(errutil.StatusBadRequest, "publicdashboards.invalidTimeRange", errutil.WithPublicMessage("Invalid time range")) | |||
ErrInvalidShareType = errutil.NewBase(errutil.StatusBadRequest, "publicdashboards.invalidShareType", errutil.WithPublicMessage("Invalid share type")) | |||
|
|||
ErrPublicDashboardPaused = errutil.NewBase(errutil.StatusForbidden, "publicdashboards.paused", errutil.WithPublicMessage("Public dashboard paused")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change we are introducing a new concept 'paused' which is a friendly way to tell the user that a dashboard is disabled. I think we should not use this concept in the backend. I prefer to continue using 'disabled' or 'notEnabled' for consistency and let the frontend to choose how to communicate this state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. gonna make those changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, we still need to set the "Public dashboard paused" message, since the idea to that message is to be shown directly in the tooltip component, without any translation
@owensmallwood that's a good point. I'm checking and some attributes are null when pubdash is paused/deleted. Gonna make some research |
After some research:
|
Some updates here:
Gonna make those changes @evictorero @owensmallwood |
What is this feature?
When an admin user pauses or deletes a public dashboard, then the viewer shows a new screen with the proper message.
Which issue(s) does this PR fix?:
Fixes #63953
Special notes for your reviewer:
new-pubdash-not-available.mov