Frontend: Fix broken links in /plugins when pathname has a trailing slash #64348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andresmgot just helped me, I was missing the trailing / in the URL (was testing with /plugins instead of /plugins/), now I can reproduce it 🤦♂️
|
leventebalogh
approved these changes
Mar 8, 2023
| const location = useLocation(); | ||
| const pathName = config.appSubUrl + location.pathname; | ||
| const { pathname } = useLocation(); | ||
| const pathName = config.appSubUrl + (pathname.endsWith('/') ? pathname.slice(0, -1) : pathname); |
There was a problem hiding this comment.
Although I think probably the best would be if the last item in the chain (PluginListItem) would do the validation - so whatever gets passed in it renders the correct links -, this change does the job as well. 👍
gassiss
added
no-changelog
leventebalogh
added
backport v9.3.x
backport v9.4.x
gassiss
changed the title
eleijonmarck
pushed a commit
that referenced
this pull request
Mar 13, 2023
…lash (#64348) Fix broken links in /plugins when pathname has a trailing slash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that makes all plugin links in the plugins page 404.
When on
/plugins/route (with the trailing slash), the links get broken:Which makes every plugin link 404: