EditDataSources: Add EditDataSourceActions to EditDataSourcePages #64487
Conversation
mikkancso
changed the title
|
If topnav is turned off then we put action buttons below the title, and that's by design - in general. For this particular case, I don't know if this is what we want. @teddyba, could you please take a look at the picture above? |
|
In the case where topnav is turned off, I think we should have the buttons in one place or another, but not both. It doesn't matter to me where they live - I think neither placement is ideal (the lower placement is not a good place for CTAs, and the top placement without the topnav makes the header cluttered.) I would maybe lean towards the former option - keeping the buttons at the bottom if topnav is turned off. One thing to note about the header with topnav - we should definitely keep the CTA as "Save and test" NOT "Save changes." The ability to test a datasource connection is really important to our users. |
|
This pull request was removed from the 9.5.0 milestone because 9.5.0 is currently being released. |
|
I'm sorry folks, that I left this PR hanging for so long, I had many other duties. We talked about this with @teddyba, and we came to the following proposal: [Topnav OFF] [Topnav ON]
Footer:
That also means we want to remove the Back button. We hope users can use the new navigation to navigate back. |
mikkancso
force-pushed
the
mikkancso/58311-update-data-source-edit-page-header
branch
from
9933bf3
to
657a8e6
Compare
public/app/features/datasources/components/EditDataSourceActions.tsx
Outdated
Show resolved
Hide resolved
mikkancso
force-pushed
the
mikkancso/58311-update-data-source-edit-page-header
branch
from
54dae2e
to
70c1fdc
Compare
|
Rebased the branch to re-trigger drone |
mikkancso
deleted the
mikkancso/58311-update-data-source-edit-page-header
branch
…4487) * add EditDataSourceActions to EditDataSourcePages * fix tests * EditDSPage: do not show buttons in header if topnav is off * remove delete button from the header * EditDSPage: hide buttons from footer when topnav is on * update tests * rename ActionProps to Props * wrap setting of feature toggle in act in jest test * fix jest test by using waitFor
What is this feature?
Adding action buttons in the header of EditDataSourcePage at both occurrences, namely under Connections and Admin.
Screencast from 2023-03-09 09-00-36.webm
UPDATE:
[Topnav OFF]
Do not show buttons in the header. Leave buttons as they are in the footer.
[Topnav ON]
Header:
Footer:
That also means we want to remove the Back button.
Which issue(s) does this PR fix?:
Fixes #58311