PublicDashboards: Enable creation when dashboard has template variables #64560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanicabanas
requested review from
axelavargas and
polibb
and removed request for
a team
evictorero
approved these changes
Mar 10, 2023
@evictorero you're right. gonna make that change |
evictorero
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
It lets a user create a public dashboard even if the dashboard has template variables, taking into account not all panels may apply those template variables.
A warning message is still shown.
Which issue(s) does this PR fix?:
Fixes #64437
Special notes for your reviewer:
template-variables.mov