Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications: Enable display of trace ID by default #64884

Merged
merged 1 commit into from Mar 21, 2023
Merged

Notifications: Enable display of trace ID by default #64884

merged 1 commit into from Mar 21, 2023

Conversation

ashharrison90
Copy link
Contributor

What is this feature?

  • removes the tracing feature flag
  • enables display of trace ID in error notifications by default

Why do we need this feature?

  • better debugging for customers

Who is this feature for?

  • everyone!

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

@ashharrison90 ashharrison90 added this to the 9.5.0 milestone Mar 16, 2023
@ashharrison90 ashharrison90 self-assigned this Mar 16, 2023
@ashharrison90 ashharrison90 requested review from a team and chri2547 as code owners March 16, 2023 10:17
@ashharrison90 ashharrison90 requested review from tskarhed, yaelleC, jackw, papagian, zserge and suntala and removed request for a team March 16, 2023 10:17
gabor
gabor approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@gabor gabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
(though probably someone from user-essentials should review it too 😄 )

@github-actions
Copy link
Contributor

⚠️   Possible breaking changes

(Open the links below in a new tab to go to the correct steps)

grafana-data has possible breaking changes (more info)

Console output
Read our guideline

@grafanabot grafanabot added the levitate breaking change A label indicating a breaking change and assigned by Levitate. label Mar 16, 2023
chri2547
chri2547 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@chri2547 chri2547 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs lgtm. Thank you.

@ashharrison90 ashharrison90 merged commit 9ca01cc into main Mar 21, 2023
19 of 20 checks passed
@ashharrison90 ashharrison90 deleted the ash/enable-tracing-by-default branch March 21, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshhunt joshhunt joshhunt approved these changes

@gabor gabor gabor approved these changes

@chri2547 chri2547 chri2547 approved these changes

@kaydelaney kaydelaney Awaiting requested review from kaydelaney

@tskarhed tskarhed Awaiting requested review from tskarhed tskarhed is a code owner automatically assigned from grafana/grafana-frontend-platform

@yaelleC yaelleC Awaiting requested review from yaelleC yaelleC is a code owner automatically assigned from grafana/grafana-frontend-platform

@jackw jackw Awaiting requested review from jackw jackw was automatically assigned from grafana/plugins-platform-frontend

@papagian papagian Awaiting requested review from papagian papagian was automatically assigned from grafana/backend-platform

@zserge zserge Awaiting requested review from zserge zserge was automatically assigned from grafana/backend-platform

@suntala suntala Awaiting requested review from suntala suntala was automatically assigned from grafana/backend-platform

Assignees

@ashharrison90 ashharrison90

Labels
add to changelog area/backend area/frontend levitate breaking change A label indicating a breaking change and assigned by Levitate. no-backport Skip backport of PR type/docs
Projects
Grafana Frontend Platform
Archived in project
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ashharrison90 @joshhunt @gabor @chri2547 @grafanabot