Alerting: Elide requests to Loki if nothing should be recorded #65011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexweav
added
type/bug
area/alerting
gotjosh
approved these changes
Mar 20, 2023
| @@ -62,6 +62,11 @@ func (h *AnnotationBackend) Record(ctx context.Context, rule history_model.RuleM | |||
| panel := parsePanelKey(rule, logger) | |||
|
|
|||
| errCh := make(chan error, 1) | |||
| if len(annotations) == 0 { | |||
There was a problem hiding this comment.
My only concern is that there's no distinction between recording and not recording to the caller of this function - but maybe this is captures by metrics and therefore is fine?
There was a problem hiding this comment.
That's how it already works to begin with. Right now the scheduler and state packages call Record on every evaluation, and they pass in in tons of states that we don't actually care about or actually want to record, like Alerting->Alerting. Regardless of this change, it relies on getting called a ton and nothing in the caller cares if it recorded or didn't.
grafanabot
pushed a commit
that referenced
this pull request
Mar 21, 2023
Exit early if no log streams or annotations (cherry picked from commit e39d7f4)
gotjosh
pushed a commit
that referenced
this pull request
Mar 27, 2023
Exit early if no log streams or annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
State history does filtering on state transitions and chooses not to write when nothing has changed.
When this happens, we'd have an empty slice of streams - we'd still attempt to write to Loki in this case, resulting in a pointless empty push request.
Now we exit early when this happens. This PR cuts down on a lot of outgoing loki traffic.
There was a similar change in Annotations to do this same thing, but for the database. Refactored this to exit even earlier. Now we don't even start any goroutines if there's nothing to write.
Which issue(s) does this PR fix?:
n/a
Special notes for your reviewer: