Logs Samples: Panel wrongly visible when using datasource without Log-Sample support #65041
Labels
area/explore
prio/high
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
type/bug
What happened:
We added the
Logs sample
feature a couple of weeks ago. That panel is used for datasources which can provide samples of logs when their data representation is not logs. With other words, this is mainly used for Loki's metric queries to see some samples of the underlying log data.However with the change in #63036 the relevant logic to display or hide the container was changed.
Basically the container relies on this logic here:
https://github.com/grafana/grafana/blob/main/public/app/features/explore/Explore.tsx#L578
Mainly, when
logsSample.dataProvider
is undefined the panel will be hidden. However in #63036 there was a change of the default return value of such data providers: https://github.com/grafana/grafana/pull/63036/files#diff-dd4066243e4f35893e0fa409792e0901d44cebd250b8fc3784e1a1d0718b5782R129-R132What you expected to happen:
Logs sample
container for other datasources then Loki.How to reproduce it (as minimally and precisely as possible):
Logs sample
is visible below the trace result tableEnvironment:
The text was updated successfully, but these errors were encountered: