Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus Metrics: Add missing stat_total_teams metric #65133

Merged
merged 3 commits into from Mar 22, 2023
Merged

Prometheus Metrics: Add missing stat_total_teams metric #65133

merged 3 commits into from Mar 22, 2023

Conversation

gamab
Copy link
Contributor

@gamab gamab commented Mar 21, 2023

What is this feature?

Seems like we have a stat for counting teams in the usage report, but we don't have the equivalent in the prometheus metrics. This PR intends to add the metric.

Why do we need this feature?

Who is this feature for?

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.
  • There are no known compatibility issues with older supported versions of Grafana, or plugins.
  • It passes the Hosted Grafana feature readiness review for observability, scalability, performance, and security.

@gamab gamab self-assigned this Mar 21, 2023
@gamab gamab added add to changelog no-backport Skip backport of PR labels Mar 21, 2023
@gamab gamab added this to the 9.5.0 milestone Mar 21, 2023
@gamab gamab marked this pull request as ready for review March 21, 2023 16:44
@gamab gamab requested a review from a team as a code owner March 21, 2023 16:44
@gamab gamab requested review from zserge, mildwonkey, suntala, sakjur and alexanderzobnin and removed request for a team March 21, 2023 16:44
@gamab gamab merged commit 895d4cc into main Mar 22, 2023
11 checks passed
@gamab gamab deleted the gamab/ac/add-total-teams-metric branch March 22, 2023 08:14
gotjosh pushed a commit that referenced this pull request Mar 27, 2023
@gamab @gotjosh
Prometheus Metrics: Add missing stat_total_teams metric (#65133)
60761e9 
* Prometheus Metrics: Add missing stat_total_teams metric
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleijonmarck eleijonmarck eleijonmarck approved these changes

@zserge zserge Awaiting requested review from zserge zserge was automatically assigned from grafana/backend-platform

@mildwonkey mildwonkey Awaiting requested review from mildwonkey mildwonkey was automatically assigned from grafana/backend-platform

@suntala suntala Awaiting requested review from suntala suntala was automatically assigned from grafana/backend-platform

@sakjur sakjur Awaiting requested review from sakjur

@alexanderzobnin alexanderzobnin Awaiting requested review from alexanderzobnin

Assignees

@gamab gamab

Labels
add to changelog area/backend no-backport Skip backport of PR
Projects
None yet
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gamab @eleijonmarck @grafanabot