Alerting: Fix attachment of external labels to Loki state history log streams #65140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexweav
added
type/bug
area/alerting
alexweav
commented
Mar 21, 2023
| @@ -74,6 +74,7 @@ func NewLokiConfig(cfg setting.UnifiedAlertingStateHistorySettings) (LokiConfig, | |||
| BasicAuthUser: cfg.LokiBasicAuthUsername, | |||
| BasicAuthPassword: cfg.LokiBasicAuthPassword, | |||
| TenantID: cfg.LokiTenantID, | |||
| ExternalLabels: cfg.ExternalLabels, | |||
There was a problem hiding this comment.
This is the entire fix, everything else is just tests
gotjosh
approved these changes
Mar 21, 2023
grobinson-grafana
approved these changes
Mar 21, 2023
gotjosh
pushed a commit
that referenced
this pull request
Mar 27, 2023
… streams (#65140) Fix attachment of external labels, add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
The Loki state history did not properly map configured external labels through the config struct. As a result, external labels were missing.
Why do we need this feature?
Fix the above bug.
Who is this feature for?
Operators wanting to use external labels.
Which issue(s) does this PR fix?:
n/a
Special notes for your reviewer:
Please check that: