Units: Format currency with negative before the symbol #65152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantxu
requested review from
tskarhed,
JoaoSilvaGrafana and
mckn
and removed request for
a team
|
You have successfully added a new CodeQL configuration |
baldm0mma
approved these changes
Mar 22, 2023
baldm0mma
reviewed
Mar 22, 2023
| @@ -5,16 +5,23 @@ import { scaledUnits, ValueFormatter } from './valueFormats'; | |||
| export function currency(symbol: string, asSuffix?: boolean): ValueFormatter { | |||
| const units = ['', 'K', 'M', 'B', 'T']; | |||
| const scaler = scaledUnits(1000, units); | |||
| return (size: number, decimals?: DecimalCount, scaledDecimals?: DecimalCount) => { | |||
| if (size === null) { | |||
| return (value: number, decimals?: DecimalCount, scaledDecimals?: DecimalCount) => { | |||
There was a problem hiding this comment.
Good change here, value makes way more sense.
Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
We currently format negative monies as
$-100and it should be-$100Why do we need this feature?
to be more normal
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Fixes #65123
Special notes for your reviewer:
Please check that: