Dashboard: Empty/No Panels dashboard with a new design #65161
Conversation
…to choose a library panel to create
polibb
added
area/dashboard
area/frontend
add to changelog
no-backport
|
You have successfully added a new CodeQL configuration |
axelavargas
requested review from
a team,
axelavargas and
juanicabanas
and removed request for
a team
public/app/features/dashboard/components/AddLibraryPanelWidget/AddLibraryPanelWidget.tsx
Outdated
Show resolved
Hide resolved
| fontWeight: 600, | ||
| }), | ||
| headerBig: css({ | ||
| fontSize: '32px', |
There was a problem hiding this comment.
we have ${theme.typography.....} for font size
There was a problem hiding this comment.
yes, but it's not useful in those cases imo - There are no 32 and 20 options, and I'd have to use theme.typography.h5 for the smaller body texts for Add row and Add library panel, which semantically doesn't make sense to me
There was a problem hiding this comment.
mmm no, me neither. isn't there any other? take into account this approach lets you modify all the app if suddenly 32px is not the desired one
There was a problem hiding this comment.
Yes, you're right it will be better to allow the single source of truth to apply here as well. I changed the header sections to h1 and h2, and the body sections to h4 and h5. It's better also because the typography we use uses rem, so in the long run any general changes will affect the details very well.
@Ijin08 would you take a look at this:
and the conversation here: Is it alright to continue with those dimensions?
The typography options we have are here: https://github.com/grafana/grafana/blob/redesign/empty-dashboard/packages/grafana-data/src/themes/createTypography.ts#L118
polibb
requested review from
joshhunt,
ashharrison90,
academo,
zserge,
mildwonkey and
suntala
and removed request for
a team
docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Awesome work @polibb 🥳 , code looks nice, also gave it a quick test on my local, and the page looks awesome.
What is this feature?
This feature allows users to easily know what is possible with an empty dashboard. The basic ingredients are on their screen ready to use.
Why do we need this feature?
Because it makes it easy to feel comfortable with grafana dashboards.
Who is this feature for?
Everyone
Which issue(s) does this PR fix?:
Fixes #63938
Please check that: