Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phlare: Fix error when there are no profileTypes to send from backend #65455

Merged
merged 1 commit into from Mar 30, 2023
Merged

Phlare: Fix error when there are no profileTypes to send from backend #65455

merged 1 commit into from Mar 30, 2023

Conversation

aocenas
Copy link
Member

@aocenas aocenas commented Mar 28, 2023

Fixes: #65356

Makes sure we send at least an empty array to the frontend so it does not blow up.

@aocenas aocenas requested a review from a team as a code owner March 28, 2023 14:10
@aocenas aocenas requested a review from simonswine March 28, 2023 14:11
@aocenas aocenas added this to the 9.5.0 milestone Mar 28, 2023
@aocenas aocenas added the no-backport Skip backport of PR label Mar 28, 2023
@aocenas aocenas merged commit abec183 into main Mar 30, 2023
19 checks passed
@aocenas aocenas deleted the aocenas/phlare/send-empty-profile-type-array branch March 30, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrapereira adrapereira adrapereira approved these changes

@joey-grafana joey-grafana joey-grafana approved these changes

@simonswine simonswine Awaiting requested review from simonswine

Assignees
No one assigned
Labels
add to changelog area/backend datasource/Phlare Phlare datasource no-backport Skip backport of PR type/bug
Projects
None yet
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.

Explore/Phlare fails when there are no ProfileTypes returned.
4 participants
@aocenas @adrapereira @joey-grafana @grafanabot