Alerting: Choose a previous valid AM configuration in case of error #65746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added method to fetch them from the API and its corresponding action and reducer
VikaCep
added
no-backport
Due to the latest backend changes, we no longer will provide the option to edit previous AM configurations in a textearea. Instead users will only be allowed to reset to a specific one with the same content. For this reason the textearea for old conf igurations is disabled and a different form action (not submit) is executed on the "reset config" button. The updateAlertManage rConfigAction is reset to its old functionality due to these changes.
VikaCep
force-pushed
the
alerting/reset-to-previous-am-configurations
branch
from
0392c4f
to
cba7703
Compare
|
You have successfully added a new CodeQL configuration |
We'll need it to pass as a parameter to the new reset endpoint
VikaCep
force-pushed
the
alerting/reset-to-previous-am-configurations
branch
from
69eb0d0
to
2b8ae89
Compare
soniaAguilarPeiron
approved these changes
Apr 3, 2023
konrad147
reviewed
Apr 3, 2023
public/app/features/alerting/unified/components/admin/AlertmanagerConfigSelector.tsx
Show resolved
Hide resolved
gillesdemey
approved these changes
Apr 3, 2023
public/app/features/alerting/unified/components/admin/AlertmanagerConfigSelector.tsx
Outdated
Show resolved
Hide resolved
public/app/features/alerting/unified/components/admin/AlertmanagerConfig.tsx
Show resolved
Hide resolved
|
This pull request was removed from the 9.5.0 milestone because 9.5.0 is currently being released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR is based on the backend work from #65728 and displays a dropdown with valid AM configurations when the current configuration is invalid so that the user can then choose one from the list to start their Alertmanager.
Why do we need this feature?
Currently if the Alertmanager fails to start, an error message is displayed and the user is basically locked out of Grafana Alerting. A lot of safeguards were added in order to avoid having bad configs saved in the database, but it's impossible to take into account each and every edge case, so this feature works as a sort of "escape hatch".
How will this work?
When there's an invalid configuration, the user is shown an error message and prompted to choose from a list of old, valid configurations
IMPORTANT NOTE: All commits until 1a91808 have been cherry-picked from #59516 which was already approved. The referenced PR was closed because the backend branch it was based off was closed and reimplemented in a new one.
Last 4 commits are new and they address the following changes that are worth to be mentioned:
POST /api/alertmanager/grafana/config/history/<id>/_activate) has been added for this scenario. When the reset button is clicked it gets called passing the old configuration id.Fixes #54505