Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DashlistPanel: Add options to include time range and variable values #65757

Merged
merged 3 commits into from
Apr 5, 2023
Merged

DashlistPanel: Add options to include time range and variable values #65757

merged 3 commits into from
Apr 5, 2023

Conversation

VictorColomb
Copy link
Contributor

What is this feature?

This PR adds two new options to the Dashboard List panel:

  • Time range - option to propagate the currently selected time range to the dashboard links,
  • Variable values - option to propagate the currently selected template variables to the dashboard links.

Screenshot 2023-04-01 175759

This feature is the equivalent of the already existing options on Dashboard Links.

Why do we need this feature?

This feature increases coherence between Dashboard Links and the Dashboard List panel.

This feature fluidifies user interaction and improves user experience when navigating between dashboards, all the while using the Dashboard List panel which imho is more user-friendly than dashboard links.

Which issue(s) does this PR fix?:

Fixes #65129

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.
  • There are no known compatibility issues with older supported versions of Grafana, or plugins.
  • It passes the Hosted Grafana feature readiness review for observability, scalability, performance, and security.

* Added documentation for the Time range option
* Added documentation for the Variable values option
@VictorColomb VictorColomb requested review from a team and imatwawana as code owners April 1, 2023 16:14
@VictorColomb VictorColomb requested review from joshhunt and JoaoSilvaGrafana and removed request for a team April 1, 2023 16:14
@CLAassistant
Copy link

CLAassistant commented Apr 1, 2023

CLA assistant check
All committers have signed the CLA.

@grafanabot grafanabot added type/docs area/frontend pr/external This PR is from external contributor labels Apr 1, 2023
Copy link
Collaborator

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some wording edits for style and clarity.

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Copy link
Collaborator

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pr-codeql-analysis-javascript.yml:analyze. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@JoaoSilvaGrafana JoaoSilvaGrafana added this to the 10.0.0 milestone Apr 4, 2023
Copy link
Contributor

@JoaoSilvaGrafana JoaoSilvaGrafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@JoaoSilvaGrafana JoaoSilvaGrafana merged commit 2f495e1 into grafana:main Apr 5, 2023
13 checks passed
@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend no-backport Skip backport of PR pr/external This PR is from external contributor type/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants