Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging: Remove chkconfig dependency #65887

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Conversation

DanCech
Copy link
Collaborator

@DanCech DanCech commented Apr 4, 2023

This dependency prevents installation on recent opensuse as they no longer provide chkconfig.

As far as I can tell we don't use it anywhere so it shouldn't be required under any modern linux using systemd,

This dependency prevents installation on recent opensuse as they no longer provide chkconfig.

As far as I can tell we don't use it anywhere so it shouldn't be required under any modern linux using systemd,
@DanCech DanCech added this to the 9.6.0 milestone Apr 4, 2023
@DanCech DanCech requested a review from a team April 4, 2023 07:33
@DanCech DanCech merged commit d072b62 into main Apr 4, 2023
@DanCech DanCech deleted the remove-chkconfig-dependency branch April 4, 2023 11:05
@zerok zerok modified the milestones: 9.6.0, 10.0.0 Apr 4, 2023
@kminehart
Copy link
Contributor

@DanCech We have references to chkconfig in our postinst script for rpm. There's just an if statement to suggest sysvinit if it exists.

To me this shows that we should just remove all sysvinit related stuff from our rpm/deb packages, wdyt?

@DanCech
Copy link
Collaborator Author

DanCech commented Apr 5, 2023

At this point I think it's reasonable to drop sysvinit support, given that the distros we support in our packaging have all switched to systemd 8+ years ago.

https://en.wikipedia.org/wiki/Systemd#Adoption

VikaCep pushed a commit that referenced this pull request Apr 5, 2023
Remove chkconfig dependency

This dependency prevents installation on recent opensuse as they no longer provide chkconfig.

As far as I can tell we don't use it anywhere so it shouldn't be required under any modern linux using systemd,
@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants