Annotations: Ignore unique constraint violations for tags #65935
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
When creating annotations with tags very fast, there's a race condition where the
tag
table might have tags added simultaneously triggering a unique constraint violation.Considerations:
Instead, I opted for a single retry which seems to work well according to my testing using k6 (I'm not able to write a reliable reproduction test in Go, since this depends on a race condition).
Who is this feature for?
Annotations API users.
Which issue(s) does this PR fix?:
Fixes #61203
Special notes for your reviewer:
excerpt from k6 script for duplication and validation
Please check that: