Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design System: Set TextArea to display: block in order to remove spacing below #66262

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Design System: Set TextArea to display: block in order to remove spacing below #66262

merged 1 commit into from
Apr 13, 2023

Conversation

L-M-K-B
Copy link
Contributor

@L-M-K-B L-M-K-B commented Apr 11, 2023 •
edited
Loading

Fixes #55804

Examples for affected use cases of TextArea:

In order to check whether the change breaks the layout I went through the following use cases:
  • packages/grafana-ui/src/components/DataSourceSettings/CertificationKey.tsx
  • packages/grafana-ui/src/components/Forms/Form.story.tsx
  • public/app/features/plugins/sql/components/configuration/TLSSecretsConfig.tsx
  • public/app/features/alerting/unified/components/admin/ConfigEditor.tsx
  • public/app/features/alerting/unified/components/silences/SilencesEditor.tsx
  • public/app/features/correlations/Forms/ConfigureCorrelationBasicInfoForm.tsx
  • public/app/features/dashboard/components/PanelEditor/getPanelFrameOptions.tsx
  • public/app/features/dashboard/components/SaveDashboard/forms/SaveDashboardForm.tsx
  • public/app/features/dashboard/components/SaveDashboard/forms/SaveProvisionedDashboardForm.tsx
  • public/app/features/dashboard/components/ShareModal/ShareEmbed.tsx
  • public/app/features/explore/RichHistory/RichHistoryCard.tsx
  • public/app/features/manage-dashboards/DashboardImportPage.tsx

I case there is some use case where the layout breaks please let me know.

@L-M-K-B L-M-K-B added area/frontend add to changelog no-backport Skip backport of PR saga design system Issues related to the work of the Saga Design System labels Apr 11, 2023
@L-M-K-B L-M-K-B added this to the 10.0.0 milestone Apr 11, 2023
@github-actions
Copy link
Contributor

Backend code coverage report for PR #66262
No changes

@github-actions
Copy link
Contributor

Frontend code coverage report for PR #66262

Plugin Main PR Difference
explore 86.46% 86.46% 0%

@L-M-K-B L-M-K-B marked this pull request as ready for review April 11, 2023 15:10
@L-M-K-B L-M-K-B requested review from a team as code owners April 11, 2023 15:10
@L-M-K-B L-M-K-B requested review from joshhunt, yaelleC and a team and removed request for a team April 11, 2023 15:10
@L-M-K-B L-M-K-B modified the milestones: 10.0.0, 9.5.1, 9.5.x Apr 11, 2023
JoaoSilvaGrafana
JoaoSilvaGrafana approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@JoaoSilvaGrafana JoaoSilvaGrafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@L-M-K-B L-M-K-B requested a review from Elfo404 April 12, 2023 13:55
@L-M-K-B L-M-K-B merged commit 725f29e into main Apr 13, 2023
@L-M-K-B L-M-K-B deleted the laura/refactor-textarea-to-remove-spacing branch April 13, 2023 12:21
alexmobo pushed a commit that referenced this pull request Apr 14, 2023
@L-M-K-B
Design System: Set TextArea to display: block in order to remove spac…
e6e7a75 
…ing below (#66262)

refactor: set textarea to display: block and add margin
@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elfo404 Elfo404 Elfo404 approved these changes

@JoaoSilvaGrafana JoaoSilvaGrafana JoaoSilvaGrafana approved these changes

@joshhunt joshhunt Awaiting requested review from joshhunt joshhunt is a code owner automatically assigned from grafana/grafana-frontend-platform

@yaelleC yaelleC Awaiting requested review from yaelleC yaelleC is a code owner automatically assigned from grafana/grafana-frontend-platform

Assignees
No one assigned
Labels
add to changelog area/explore area/frontend no-backport Skip backport of PR saga design system Issues related to the work of the Saga Design System
Projects
Saga Design System
Status: ✅ Done
Milestone
10.0.0-preview
Development

Successfully merging this pull request may close these issues.

TextArea: textareas have an extra spacing at the bottom
5 participants
@L-M-K-B @Elfo404 @JoaoSilvaGrafana @zerok @grafanabot