Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GrafanaUI: Remove obsolete logs exports #66268

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Conversation

gabor
Copy link
Contributor

@gabor gabor commented Apr 11, 2023

(fixes #65779)

in #55364 we deprecated the 4 exported logs-functions/classes from grafana-ui, this pull-request deletes them.

(we delete the whole Logs folder, because we removed the only exports published from the folder)

NOTE: we checked in the plugin dashboard, and none of those plugins were using any of these exports.

Release notice breaking change

We removed previously deprecated components from @grafana/ui : LogLabels, LogMessageAnsi, LogRows, getLogRowStyles.

@gabor gabor added add to changelog no-backport Skip backport of PR labels Apr 11, 2023
@gabor gabor added this to the 10.0.0 milestone Apr 11, 2023
@gabor gabor added the breaking change Relevant for changelog generation label Apr 11, 2023
@gabor gabor marked this pull request as ready for review April 11, 2023 12:04
@gabor gabor requested review from a team as code owners April 11, 2023 12:04
@gabor gabor requested review from joshhunt and ashharrison90 and removed request for a team April 11, 2023 12:04
@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2023

⚠️   Possible breaking changes

(Open the links below in a new tab to go to the correct steps)

grafana-ui has possible breaking changes (more info)

Console output
Read our guideline

@grafanabot grafanabot added the levitate breaking change A label indicating a breaking change and assigned by Levitate. label Apr 11, 2023
@gabor gabor changed the title grafana-ui: removed obsolete logs exports Grafana-ui: Remove obsolete logs exports Apr 11, 2023
@gabor gabor changed the title Grafana-ui: Remove obsolete logs exports GrafanaUI: Remove obsolete logs exports Apr 12, 2023
@gabor gabor requested a review from tolzhabayev as a code owner April 12, 2023 07:00
Copy link
Contributor

@joshhunt joshhunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Satisfied that no known plugins are using these components 👍🏻

@gabor gabor merged commit 18cb2ac into main Apr 12, 2023
@gabor gabor deleted the gabor/remove-deprecated-grafana-ui branch April 12, 2023 13:41
alexmobo pushed a commit that referenced this pull request Apr 14, 2023
* grafana-ui: removed obsolete logs exports

* updated betterer stats

* updated CODEOWNERS
@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend breaking change Relevant for changelog generation levitate breaking change A label indicating a breaking change and assigned by Levitate. no-backport Skip backport of PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs: remove already-deprecated code in grafana-ui
5 participants