Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GrafanaData: Remove obsolete logs exports #66271

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

gabor
Copy link
Contributor

@gabor gabor commented Apr 11, 2023

(fixes #65778)

in #56242 and in #56077 we deprecated certain logs-related exports from grafana-data, this pull-request deletes them.

NOTE: we checked in the plugin dashboard, and none of those plugins were using any of these exports.

Release notice breaking change

We removed previously deprecated components from @grafana/data : getLogLevel, getLogLevelFromKey, addLogLevelToSeries, LogsParser, LogsParsers, calculateFieldStats, calculateLogsLabelStats, calculateStats, getParser, sortInAscendingOrder, sortInDescendingOrder, sortLogsResult, sortLogRows, checkLogsError, escapeUnescapedString.

Base automatically changed from gabor/remove-deprecated-grafana-ui to main April 12, 2023 13:41
@gabor gabor force-pushed the gabor/remove-deprecated-grafana-data branch from dd8657f to 2558c44 Compare April 12, 2023 13:42
@gabor gabor changed the title grafana-data: removed obsolete logs exports GrafanaData: Remove obsolete logs exports Apr 12, 2023
@gabor gabor added add to changelog no-backport Skip backport of PR breaking change Relevant for changelog generation labels Apr 12, 2023
@gabor gabor added this to the 10.0.0 milestone Apr 12, 2023
@gabor gabor marked this pull request as ready for review April 12, 2023 13:51
@gabor gabor requested review from a team as code owners April 12, 2023 13:51
@gabor gabor requested review from joshhunt, ashharrison90 and andresmgot and removed request for a team April 12, 2023 13:51
@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2023

⚠️   Possible breaking changes

(Open the links below in a new tab to go to the correct steps)

grafana-data has possible breaking changes (more info)

Console output
Read our guideline

@grafanabot grafanabot added the levitate breaking change A label indicating a breaking change and assigned by Levitate. label Apr 12, 2023
@gabor gabor merged commit 8328906 into main Apr 13, 2023
8 of 9 checks passed
@gabor gabor deleted the gabor/remove-deprecated-grafana-data branch April 13, 2023 11:32
alexmobo pushed a commit that referenced this pull request Apr 14, 2023
* grafana-data: removed obsolete logs exports

* updated betterer checksums
@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend breaking change Relevant for changelog generation levitate breaking change A label indicating a breaking change and assigned by Levitate. no-backport Skip backport of PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs: remove already-deprecated code in grafana-data
5 participants