Alerting: Use default page size of 5000 when querying Loki for state history #66315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Previously, we use Loki's default page size for range queries. In some cases, the page size was absurdly low - 100, even. Let's use 5000 as the default page size for now.
This is a bit of a band-aid solution. The loki operator can configure
max_entries_limit_per_query
to something really low, and there's not much we can do about it.I'm posting this PR to widen things for now, but in the future we'll want to handle this limit more gracefully, by either:
config.ini
Why do we need this feature?
This is a more reasonable pagination size for this sort of query.
Which issue(s) does this PR fix?:
n/a
Special notes for your reviewer:
Please check that: