Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Clean up NavModel interface #66548

Merged
merged 4 commits into from
Apr 17, 2023
Merged

Chore: Clean up NavModel interface #66548

merged 4 commits into from
Apr 17, 2023

Conversation

ashharrison90
Copy link
Contributor

@ashharrison90 ashharrison90 commented Apr 14, 2023 •
edited
Loading

What is this feature?

Why do we need this feature?

  • keep our code tidy!

Who is this feature for?

  • grafana devs

Which issue(s) does this PR fix?:

For #61214

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

Release notice breaking change

We've removed some now unused properties from the NavModel interface.

@ashharrison90 ashharrison90 added type/chore area/navigation no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Apr 14, 2023
@ashharrison90 ashharrison90 added this to the 10.0.0 milestone Apr 14, 2023
@ashharrison90 ashharrison90 self-assigned this Apr 14, 2023
@ashharrison90 ashharrison90 requested review from a team as code owners April 14, 2023 09:00
@ashharrison90 ashharrison90 requested review from joshhunt, yaelleC, mckn, sakjur, papagian and mildwonkey and removed request for a team April 14, 2023 09:00
@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023 •
edited
Loading

⚠️   Possible breaking changes

(Open the links below in a new tab to go to the correct steps)

grafana-data has possible breaking changes (more info)

Console output
Read our guideline

@grafanabot grafanabot added the levitate breaking change A label indicating a breaking change and assigned by Levitate. label Apr 14, 2023
@ashharrison90 ashharrison90 mentioned this pull request Apr 14, 2023
Closed
4 tasks
@ashharrison90 ashharrison90 added add to changelog and removed no-changelog Skip including change in changelog/release notes labels Apr 17, 2023
@ashharrison90 ashharrison90 added the breaking change Relevant for changelog generation label Apr 17, 2023
joshhunt
joshhunt approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@joshhunt joshhunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it for a quick test drive and it looks good to me :)

@ashharrison90 ashharrison90 merged commit ab08b4f into main Apr 17, 2023
@ashharrison90 ashharrison90 deleted the ash/navmodel-interface branch April 17, 2023 15:01
adela-almasan pushed a commit that referenced this pull request Apr 17, 2023
@ashharrison90 @adela-almasan
Chore: Clean up NavModel interface (#66548)
c24be71 
* clean up navmodel interface

* remove concept of sections from NavModel interface

* clean up applinks
@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshhunt joshhunt joshhunt approved these changes

@yaelleC yaelleC Awaiting requested review from yaelleC yaelleC is a code owner automatically assigned from grafana/grafana-frontend-platform

@mckn mckn Awaiting requested review from mckn mckn is a code owner automatically assigned from grafana/plugins-platform-frontend

@sakjur sakjur Awaiting requested review from sakjur sakjur was automatically assigned from grafana/backend-platform

@papagian papagian Awaiting requested review from papagian papagian was automatically assigned from grafana/backend-platform

@mildwonkey mildwonkey Awaiting requested review from mildwonkey mildwonkey was automatically assigned from grafana/backend-platform

Assignees

@ashharrison90 ashharrison90

Labels
add to changelog area/backend area/frontend area/navigation breaking change Relevant for changelog generation levitate breaking change A label indicating a breaking change and assigned by Levitate. no-backport Skip backport of PR type/chore
Projects
Grafana Frontend Platform
Archived in project
Milestone
10.0.0-preview
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ashharrison90 @joshhunt @zerok @grafanabot