Plugins: Fix plugin catalog filtering #66663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leventebalogh
added
type/bug
area/plugins
add to changelog
no-backport
leventebalogh
requested review from
andresmgot,
jackw and
sympatheticmoose
and removed request for
a team
andresmgot
approved these changes
Apr 17, 2023
| @@ -55,7 +55,7 @@ export default function Browse({ route }: GrafanaRouteComponentProps): ReactElem | |||
| }; | |||
|
|
|||
| const onSearch = (q: string) => { | |||
There was a problem hiding this comment.
not sure if it would be too complicated but it would be nice to have a test that verifies that the bug is gone with the react testing library
There was a problem hiding this comment.
Yepp, I think that's a good point, will add another test case in the afternoon 👍
sympatheticmoose
approved these changes
Apr 17, 2023
andresmgot
reviewed
Apr 18, 2023
| @@ -20,6 +20,7 @@ const useDebounceWithoutFirstRender = (callBack: () => any, delay = 0, deps: Rea | |||
| isFirstRender.current = false; | |||
| return; | |||
| } | |||
| console.log('--------- DEBUOUNCE'); | |||
There was a problem hiding this comment.
I think you forgot to remove these @leventebalogh 😅
There was a problem hiding this comment.
Quickfix for removing them 😅
#66725
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66478
What changed?
Updated the filtering in the plugins catalog to be able to use the different filters together. Also added some tests for the
find()selector.Screen.Recording.2023-04-17.at.13.34.28.mov