-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APIkeys: Add metrics for apikey endpoints #66732
Conversation
Hello @eleijonmarck!
Please, if the current pull request addresses a bug fix, label it with the |
Hi @eleijonmarck - backporting to 9.4 should help us gather much needed metrics to help guide the deprecation of API keys. Approved from Product. |
Since we want these stats now and we're backporting I understand placing them in Hopefully these counters can be removed soon |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-66732-to-v9.4.x origin/v9.4.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x c505d26430e85baa20429675c8958d42ea67adf4
# Push it to GitHub
git push --set-upstream origin backport-66732-to-v9.4.x
git switch main
# Remove the local backport branch
git branch -D backport-66732-to-v9.4.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-66732-to-v9.5.x origin/v9.5.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x c505d26430e85baa20429675c8958d42ea67adf4
# Push it to GitHub
git push --set-upstream origin backport-66732-to-v9.5.x
git switch main
# Remove the local backport branch
git branch -D backport-66732-to-v9.5.x Then, create a pull request where the |
this change should be reverted as we already have these metrics in place for grafana instances of OSS |
This reverts commit c505d26.
What is this feature?
added metrics:
Why do we need this feature?
This is needed for monitoring of the use of API keys for users as part of the deprecation strategy
OG issue: #53567