New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Fix DatasourceUID and RefID missing for DatasourceNoData alerts #66733
Conversation
Hello @grobinson-grafana!
Please, if the current pull request addresses a bug fix, label it with the |
The lack of unit tests is because this function isn't even tested. I'm going to create the tests for this in another PR and then rebase main onto this when those tests are committed. |
…erts This commit fixes a bug where DatasourceUID and RefID annotations are missing for DatasourceNoData alerts in Grafana 9.5. This bug affects datasource plugins that have moved to using the data plane contract.
9b36805
to
db99d98
Compare
Tagging @itsmylife, @kylebrandt and @ryantxu (for an FYI) as this was introduced in #62254. We're happy to review other changes you make around this area as you implement more of the data plane contract on other data sources t to ensure we're not affected. We promise not to slow you down and review promptly 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…NoData alerts (#66962) Alerting: Fix DatasourceUID and RefID missing for DatasourceNoData alerts (#66733) This commit fixes a bug where DatasourceUID and RefID annotations are missing for DatasourceNoData alerts in Grafana 9.5. This bug affects datasource plugins that have moved to using the data plane contract. (cherry picked from commit 35342a3) Co-authored-by: George Robinson <george.robinson@grafana.com>
…erts (#66733) This commit fixes a bug where DatasourceUID and RefID annotations are missing for DatasourceNoData alerts in Grafana 9.5. This bug affects datasource plugins that have moved to using the data plane contract.
Which issue(s) does this PR fix?:
This commit fixes a bug where DatasourceUID and RefID annotations are missing for DatasourceNoData alerts in Grafana 9.5. This bug affects datasource plugins that have moved to using the data plane contract.
This bug appears to have been introduced in #62254 which updates the Prometheus plugin to send back no data data frames as documented in the data plane contract.
Fixes #66629
Special notes for your reviewer:
Please check that: