Log Context: Add button to open the context query in a split view #66777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backend code coverage report for PR #66777 |
|
Frontend code coverage report for PR #66777
|
public/app/features/logs/components/log-context/LogRowContextModal.tsx
Outdated
Show resolved
Hide resolved
public/app/features/logs/components/log-context/LogRowContextModal.tsx
Outdated
Show resolved
Hide resolved
ivanahuckova
approved these changes
Apr 20, 2023
mdvictor
pushed a commit
that referenced
this pull request
Apr 21, 2023
…6777) * add show context button * improve type definition * change to default `maxLines` * remove context query * add provider to tests * add test for split view button * improve documentation * add tests for `getLogRowContextQuery` * refactor LogsContainer functions * fix spelling * add `contextQuery` as state * fix tests * fix lint * do not use callIfDefined * make button secondary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Adds a feature to open Log Context queries in a split view.