Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect mapping of NoData\Error to multidimensional rules #66790

Closed
yuri-tceretian opened this issue Apr 18, 2023 · 8 comments · Fixed by #68142
Closed

Incorrect mapping of NoData\Error to multidimensional rules #66790

yuri-tceretian opened this issue Apr 18, 2023 · 8 comments · Fixed by #68142
Assignees
Labels

Comments

@yuri-tceretian
Copy link
Contributor

What happened:

Execution of NoData\Error set to Ok or Alerting of multi-dimensional rules creates a new alert instance instead of setting the state of existing instances.

Example
firefox_ogGiPhA9F7.1.mp4

What you expected to happen

State of the current alert rule instances should be set according to the mapping options.

How to reproduce it (as minimally and precisely as possible):

  • Create a rule that returns multi-dimensional results
  • Wait util it is evaluated.
  • Make data source provide either NoData or Error
  • Wait for the next evaluation
  • See that a new state is created.

Anything else we need to know?:

Environment:

  • Grafana version: main-4a7ecc24
  • Data source type & version: N/A
  • OS Grafana is installed on: N/A
  • User OS & Browser: N/A
  • Grafana plugins: N/A
  • Others: N/A
@jasuade
Copy link
Member

jasuade commented Jun 5, 2023

Hey @yuri-tceretian, team, we have an escalation open regarding this topic. Thus, I wanted to ask if there is expected timeline to change this behavior or what would be the proposed action.

Thank you!

@yuri-tceretian
Copy link
Contributor Author

We discussed this issue at the weekly meeting and decided to have a PoC of the fix to estimate the outcome and affected area. We're still evaluating the proposed solution.

@jasuade
Copy link
Member

jasuade commented Jun 6, 2023

Thank you for the heads up @yuri-tceretian !

@jasuade
Copy link
Member

jasuade commented Jul 24, 2023

Hello @yuri-tceretian, just wanted to catch up with the team on this issue. Was the PoC successful, were you able to estimate the outcome and impact, is there any timeline for the fix?

Thank you for all the work!

@yuri-tceretian
Copy link
Contributor Author

Yes, I plan to finish the PR this week. There is another problem with state management I am addressing at this moment.

@Sheldun21
Copy link

Hey @yuri-tceretian I wanted to follow up as I saw this ticket reopen from our side.

Any luck with getting this completed/implemented?

Thanks for all you do!! :)

@yuri-tceretian
Copy link
Contributor Author

@Sheldun21 I am working on this. It takes more time than I expected mostly because I found some significant problems in our tests.

@yuri-tceretian
Copy link
Contributor Author

The PR has been merged. Please keep in mind that the change is behind a feature flag alertingNoDataErrorExecution and disabled by default. In the future minor, we enable it by default and then eventually remove the feature flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
3 participants