Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elasticsearch: Deprecate the usage of the database field in provisioning #66828

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Elasticsearch: Deprecate the usage of the database field in provisioning #66828

merged 2 commits into from
Apr 19, 2023

Conversation

gwdawson
Copy link
Member

@gwdawson gwdawson commented Apr 19, 2023 •
edited
Loading

What is this feature?
updates the documentation for elasticsearch datasource provisioning.
updates the provisioning files for the elastic gdev datasources

Which issue(s) does this PR fix?:
Related #59098

Special notes for your reviewer:
elastic datasources after after new provisioning

gdev-elasticsearch            || { "index":"[logs-]YYYY.MM.DD", "interval":"Daily", ... }
gdev-elasticsearch-filebeat   || { "index":"[filebeat-]YYYY.MM.DD", "interval":"Daily", ...}
gdev-elasticsearch-metricbeat || { "index":"[metricbeat-]YYYY.MM.DD", "interval":"Daily", ... }

Deprecation notice

The database field has been deprecated in the Elasticsearch datasource provisioning files, please use the index field in jsonData instead.

@gwdawson gwdawson added add to changelog no-backport Skip backport of PR labels Apr 19, 2023
@gwdawson gwdawson added this to the 10.0.0 milestone Apr 19, 2023
@gwdawson gwdawson requested review from gabor and a team April 19, 2023 10:30
@gwdawson gwdawson requested review from a team, Eve832 and GrafanaWriter as code owners April 19, 2023 10:30
@gwdawson gwdawson self-assigned this Apr 19, 2023
@gwdawson gwdawson requested review from sakjur, mildwonkey and suntala and removed request for a team April 19, 2023 10:30
@gwdawson gwdawson changed the title Elastic: Update docs and gdev provisioning Elasticsearch: Deprecate the usage of the database field in provisioning Apr 19, 2023
@gwdawson gwdawson requested a review from gabor April 19, 2023 11:25
gabor
gabor approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@gabor gabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gwdawson gwdawson merged commit 46b7354 into main Apr 19, 2023
@gwdawson gwdawson deleted the gareth/elasticsearch-provisioning-ds branch April 19, 2023 13:13
@gabor gabor mentioned this pull request Apr 19, 2023
Open
ryantxu pushed a commit that referenced this pull request Apr 19, 2023
@gwdawson @ryantxu
Elasticsearch: Deprecate the usage of the database field in provision…
3258cb8 
…ing (#66828)

* update docs and gdev provisioning

* update docs
@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabor gabor gabor approved these changes

@Eve832 Eve832 Awaiting requested review from Eve832

@GrafanaWriter GrafanaWriter Awaiting requested review from GrafanaWriter

@sakjur sakjur Awaiting requested review from sakjur sakjur was automatically assigned from grafana/backend-platform

@mildwonkey mildwonkey Awaiting requested review from mildwonkey mildwonkey was automatically assigned from grafana/backend-platform

@suntala suntala Awaiting requested review from suntala suntala was automatically assigned from grafana/backend-platform

Assignees

@gwdawson gwdawson

Labels
add to changelog no-backport Skip backport of PR type/docs
Projects
None yet
Milestone
10.0.0-preview
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gwdawson @gabor @zerok @grafanabot