Grafana/ui: Add UserIcon and UsersIndicator components #66906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarity-89
requested review from
jackw and
tskarhed
and removed request for
a team
Clarity-89
changed the title
tskarhed
reviewed
Apr 20, 2023
Comment on lines
+33
to
+44
| * Output the initials of the first and last name (if given), capitalized and concatenated together. | ||
| * If name is not provided, an empty string is returned. | ||
| * @param {string} [name] The name to extract initials from. | ||
| * @returns {string} The uppercase initials of the first and last name. | ||
| * @example | ||
| * // Returns 'JD' | ||
| * getUserInitials('John Doe'); | ||
| * // Returns 'A' | ||
| * getUserInitials('Alice'); | ||
| * // Returns '' | ||
| * getUserInitials(); | ||
| */ |
tskarhed
reviewed
Apr 20, 2023
| } | ||
|
|
||
| const limitReached = users.length > limit; | ||
| const extraUsers = users.length - limit; |
There was a problem hiding this comment.
Do we need a check here in case the limit is negative? It doesn't make any sense but you can set it in storybook to -1, it ends up with a confusing result because then if there are 5 users the extraUsers are 6 so it displays 4 user icons and then +6 🙃
There was a problem hiding this comment.
Done! Also added min param to the argType but it looks like it doesn't apply to manually typed values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Move the
UserIconandUsersIndicatorcomponents into grafana/ui.Why do we need this feature?
Enable this component to be used by other parts of Grafana + plugins.
Which issue(s) does this PR fix?:
Part of #66679.
Special notes for your reviewer:
Default state:
Active state:
With many users
Please check that: