Rendering: Fix panel rendered count on error #67027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgnesToulet
added
type/bug
area/panel/common
add to changelog
area/image-rendering
backport v9.5.x
AgnesToulet
requested review from
dprokop and
evictorero
and removed request for
a team
torkelo
approved these changes
Apr 21, 2023
grafanabot
pushed a commit
that referenced
this pull request
Apr 24, 2023
Rendering: fix panel rendered count on error (cherry picked from commit fe5a07f)
AgnesToulet
added a commit
that referenced
this pull request
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This increments the
panelsRenderedcount even if there was an error (as it still means the rendering is done).Why do we need this feature?
This is needed because currently when there is an error the counter is not incremented which causes the rendering service to wait for the timeout to be reached.
Who is this feature for?
Users of the rendering / reporting features.