Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudwatch Logs: Clarify Cloudwatch Logs Limits #67072

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

sarahzinger
Copy link
Member

@sarahzinger sarahzinger commented Apr 21, 2023

What is this feature?

  • notifies users that they can only query 50 log groups at a time

Screenshot 2023-04-21 at 4 29 59 PM

  • clarifies what cloudwatch logs time out is about

Screenshot 2023-04-21 at 4 29 44 PM

Screenshot 2023-04-21 at 4 29 30 PM

Why do we need this feature?

Who is this feature for?
Cloudwatch Logs users

Which issue(s) does this PR fix?:

Fixes #64336
Fixes #65471

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@sarahzinger sarahzinger requested a review from a team as a code owner April 21, 2023 20:20
@sarahzinger sarahzinger requested review from fridgepoet and iwysiu and removed request for a team April 21, 2023 20:20
@sarahzinger sarahzinger added backport A backport PR backport v9.5.x Bot will automatically open backport PR labels Apr 21, 2023
@sarahzinger sarahzinger added this to the 9.5.x milestone Apr 21, 2023
@sarahzinger sarahzinger added the no-changelog Skip including change in changelog/release notes label Apr 21, 2023
@grafanabot
Copy link
Contributor

Hello @sarahzinger!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@sarahzinger sarahzinger added add to changelog and removed no-changelog Skip including change in changelog/release notes labels Apr 21, 2023
@sarahzinger sarahzinger changed the title Chore: Clarify Cloudwatch Logs Limits Cloudwatch Logs: Bug Fix, Clarify Cloudwatch Logs Limits Apr 21, 2023
@sarahzinger sarahzinger changed the title Cloudwatch Logs: Bug Fix, Clarify Cloudwatch Logs Limits Cloudwatch Logs: Clarify Cloudwatch Logs Limits Apr 21, 2023
@github-actions
Copy link
Contributor

Backend code coverage report for PR #67072
No changes

@github-actions
Copy link
Contributor

Frontend code coverage report for PR #67072

Plugin Main PR Difference
cloudwatch 83.03% 83.03% 0%

Copy link
Contributor

@iwysiu iwysiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Lgtm

@sarahzinger sarahzinger merged commit 5f16cd5 into main Apr 24, 2023
@sarahzinger sarahzinger deleted the sarahzinger/cloudwatch-log-limits branch April 24, 2023 12:47
grafanabot pushed a commit that referenced this pull request Apr 24, 2023
Clarify Cloudwatch Logs Limits

(cherry picked from commit 5f16cd5)
@sarahzinger sarahzinger modified the milestones: 9.5.x, 10.0.x Apr 24, 2023
sarahzinger added a commit that referenced this pull request Apr 24, 2023
Cloudwatch Logs: Clarify Cloudwatch Logs Limits (#67072)

Clarify Cloudwatch Logs Limits

(cherry picked from commit 5f16cd5)

Co-authored-by: Sarah Zinger <sarah.zinger@grafana.com>
@zerok zerok modified the milestones: 10.0.x, 10.0.0 May 2, 2023
@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants