Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudwatch: Add FraudDetector namespace with metrics and dimensions #67318

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

ffje
Copy link
Contributor

@ffje ffje commented Apr 26, 2023

What is this feature?

The PR adds missing FraudDetector namespace, metrics and dimensions for Cloudwatch

Why do we need this feature?

When you're using the Cloudwatch as a data source and you're trying to search for 'FraudDetector' namespace grafana shows that it's missing

Who is this feature for?

Anyone who uses Amazon Fraud Detector

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@ffje ffje requested a review from a team as a code owner April 26, 2023 18:02
@ffje ffje requested review from fridgepoet and iwysiu and removed request for a team April 26, 2023 18:02
@CLAassistant
Copy link

CLAassistant commented Apr 26, 2023

CLA assistant check
All committers have signed the CLA.

@grafanabot grafanabot added area/backend datasource/CloudWatch pr/external This PR is from external contributor labels Apr 26, 2023
@iwysiu
Copy link
Contributor

iwysiu commented Apr 26, 2023

Hi @ffje , thanks for the contribution! From looking at the docs, it seems like there should be more dimensions listed?

@ffje
Copy link
Contributor Author

ffje commented Apr 26, 2023

that's right @iwysiu, thanks for noticing! Will add it soon.

@ffje
Copy link
Contributor Author

ffje commented Apr 26, 2023

hey @iwysiu I've updated the PR. However, I'm not sure it worth to keep something besides my initial proposed metrics: GetEventPrediction, GetEventPredictionLatency, GetEventPrediction4XXError, GetEventPrediction5XXError. And the only dimension - DetectorID.

AWS Cloudwatch console does not show any metrics except those. Could you please advice, should I keep as is or revert it back?
image
image

@iwysiu
Copy link
Contributor

iwysiu commented Apr 27, 2023

Thanks @ffje ! (I don't have fraud detector set to test this myself) Does using the other dimensions do anything/successfully query? If so, I'd keep them, otherwise feel free to revert it.

@ffje
Copy link
Contributor Author

ffje commented Apr 27, 2023

@iwysiu Thanks for suggestion. For my own FraudDetector setup it does nothing, however there are multiple FraudDetector types, so it might be useful for other ones. I'd keep it as is for now.

Any further steps should I do to proceed with PR? Thanks in advance. (seems I don't have permissions to put appropriate labels to make CI checks fully green)

Copy link
Contributor

@iwysiu iwysiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nope, there's nothing else you have to do, I'll handle the CI checks. Thanks again for contributing!

@iwysiu iwysiu added no-backport Skip backport of PR add to changelog labels Apr 27, 2023
@iwysiu iwysiu added this to the 10.0.0 milestone Apr 27, 2023
@iwysiu iwysiu changed the title Cloudwatch: add missing FraudDetector namespace with metrics and dimensions Cloudwatch: Add FraudDetector namespace with metrics and dimensions Apr 27, 2023
@iwysiu iwysiu merged commit 2cd98ea into grafana:main Apr 27, 2023
@ffje ffje deleted the cloudwatch-fraud-detector-namespace branch April 27, 2023 18:56
@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants