-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloudwatch: Add FraudDetector namespace with metrics and dimensions #67318
Cloudwatch: Add FraudDetector namespace with metrics and dimensions #67318
Conversation
that's right @iwysiu, thanks for noticing! Will add it soon. |
…com/ffje/grafana into cloudwatch-fraud-detector-namespace
hey @iwysiu I've updated the PR. However, I'm not sure it worth to keep something besides my initial proposed metrics: GetEventPrediction, GetEventPredictionLatency, GetEventPrediction4XXError, GetEventPrediction5XXError. And the only dimension - DetectorID. AWS Cloudwatch console does not show any metrics except those. Could you please advice, should I keep as is or revert it back? |
Thanks @ffje ! (I don't have fraud detector set to test this myself) Does using the other dimensions do anything/successfully query? If so, I'd keep them, otherwise feel free to revert it. |
@iwysiu Thanks for suggestion. For my own FraudDetector setup it does nothing, however there are multiple FraudDetector types, so it might be useful for other ones. I'd keep it as is for now. Any further steps should I do to proceed with PR? Thanks in advance. (seems I don't have permissions to put appropriate labels to make CI checks fully green) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nope, there's nothing else you have to do, I'll handle the CI checks. Thanks again for contributing!
What is this feature?
The PR adds missing FraudDetector namespace, metrics and dimensions for Cloudwatch
Why do we need this feature?
When you're using the Cloudwatch as a data source and you're trying to search for 'FraudDetector' namespace grafana shows that it's missing
Who is this feature for?
Anyone who uses Amazon Fraud Detector
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: