-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Update grafana/alerting to 4f09f51 #67329
Conversation
Should we go straight to grafana/alerting@5828396? |
Agree with Matt here, not sure I see a reason for a second PR when grafana/alerting@5828396 is fairly trivial. |
Perhaps I didn't explain the reasoning well the first time around 🙁 The reason I wanted to create two separate PRs is so we can have a 1:1 relationship between the issue and the fix.
If we do both in the same PR we have this:
I wanted to have the former so if or when we go back and look at the issues it's super clear to see which PRs fixed it, rather than having a shared PR that fixes a number of different bugs all at the same time. |
e056696
to
5608f6d
Compare
Thanks! I had to rebase main to fix a conflict in |
What is this feature?
This pull request updates
grafana/alerting
to4f09f51
to fix prometheus/alertmanager#3278.Why do we need this feature?
[Add a description of the problem the feature is trying to solve.]
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: