Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Fix misleading status code in provisioning API #67331

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Alerting: Fix misleading status code in provisioning API #67331

merged 1 commit into from
Apr 27, 2023

Conversation

usommerl
Copy link
Contributor

Fixes #66249

Which issue(s) does this PR fix?: Fix misleading status code in provisioning API

@usommerl usommerl requested a review from a team April 26, 2023 21:20
@CLAassistant
Copy link

CLAassistant commented Apr 26, 2023

CLA assistant check
All committers have signed the CLA.

@grafanabot grafanabot added area/backend pr/external This PR is from external contributor labels Apr 26, 2023
@grobinson-grafana grobinson-grafana added add to changelog backport v9.5.x Bot will automatically open backport PR labels Apr 26, 2023
@grafanabot
Copy link
Contributor

Hello @grobinson-grafana!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@grobinson-grafana grobinson-grafana added backport v9.4.x Mark PR for automatic backport to v9.4.x and removed missing-labels labels Apr 26, 2023
@grafanabot
Copy link
Contributor

Hello @grobinson-grafana!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@grobinson-grafana
Copy link
Contributor

Thank you very much for creating this! I will take a look tomorrow!

@grobinson-grafana grobinson-grafana added this to the 9.5.x milestone Apr 26, 2023
Copy link
Contributor

@grobinson-grafana grobinson-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! You can expect to see this fix in the next minor version of 9.4 and 9.5, and also 10.0.

@grobinson-grafana grobinson-grafana merged commit dfc99cd into grafana:main Apr 27, 2023
17 checks passed
grafanabot pushed a commit that referenced this pull request Apr 27, 2023
grafanabot pushed a commit that referenced this pull request Apr 27, 2023
grobinson-grafana pushed a commit that referenced this pull request Apr 27, 2023
…7357)

Alerting: Fix misleading status code in provisioning API (#67331)

Fixes #66249

(cherry picked from commit dfc99cd)

Co-authored-by: Uwe Sommerlatt <uwe.sommerlatt@gmail.com>
grobinson-grafana pushed a commit that referenced this pull request Apr 27, 2023
…7358)

Alerting: Fix misleading status code in provisioning API (#67331)

Fixes #66249

(cherry picked from commit dfc99cd)

Co-authored-by: Uwe Sommerlatt <uwe.sommerlatt@gmail.com>
@usommerl usommerl deleted the fix-grafana-66249 branch April 27, 2023 17:30
@zerok zerok modified the milestones: 9.5.x, 9.5.2, 10.0.0 May 3, 2023
@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/backend backport v9.4.x Mark PR for automatic backport to v9.4.x backport v9.5.x Bot will automatically open backport PR missing-labels pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading HTTP status code when calling endpoint GET /api/v1/provisioning/alert-rules/{UID} - Alerting
5 participants