Trace View: Export trace button #67368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrapereira
added
area/frontend
add to changelog
no-backport
adrapereira
requested review from
joshhunt and
eledobleefe
and removed request for
a team
|
Backend code coverage report for PR #67368 |
|
Frontend code coverage report for PR #67368
|
joey-grafana
approved these changes
Apr 28, 2023
| label={'Export'} | ||
| icon={'save'} | ||
| /> */} | ||
| <ActionButton onClick={exportTrace} ariaLabel={'Export Trace'} label={'Export'} icon={'save'} /> |
There was a problem hiding this comment.
Nit: we don't need the curly brackets for strings
1 task
ryantxu
pushed a commit
that referenced
this pull request
May 3, 2023
* Add export button to trace view * Support zipkin, jaeger and otlp formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR adds a new button to the trace view that allows for quick access to export the current trace.
newTraceViewHeaderfeature toggle.Why do we need this feature?
To allow quick access to export/download traces so they can easily be shared or annexed to incidents, for example.
Who is this feature for?
Users of the trace view.
Special notes for your reviewer:
Please check that: