PostgreSQL: Fix tls certificate issue by downgrading lib/pq #67372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoltanbedi
requested review from
mildwonkey and
suntala
and removed request for
a team
zoltanbedi
added
backport v9.5.x
papagian
approved these changes
Apr 27, 2023
| @@ -73,7 +73,7 @@ require ( | |||
| github.com/jmespath/go-jmespath v0.4.0 | |||
| github.com/json-iterator/go v1.1.12 | |||
| github.com/jung-kurt/gofpdf v1.16.2 | |||
| github.com/lib/pq v1.10.7 | |||
| github.com/lib/pq v1.10.6 | |||
There was a problem hiding this comment.
I would suggest adding a comment to prevent future attempts to upgrade until this is fixed
There was a problem hiding this comment.
Thanks @papagian added a comment at the bottom. Is that okay?
sakjur
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
LGTM 👍 I don't see any harm in downgrading based on looking at lib/pq@v1.10.6...v1.10.9 and lib/pq@v1.10.6...v1.10.7
grafanabot
pushed a commit
that referenced
this pull request
Apr 27, 2023
* PostgreSQL: Downgrade lib/pq * Add comment (cherry picked from commit 5c32925)
zoltanbedi
added a commit
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the issue stated in #65816 by downgrading the lib/pq library.
Which issue(s) does this PR fix?:
Fixes #65816