Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NestedFolders: Use new Browse Dashboards UI behind feature flag #67416

Merged
merged 1 commit into from May 2, 2023
Merged

NestedFolders: Use new Browse Dashboards UI behind feature flag #67416

merged 1 commit into from May 2, 2023

Conversation

joshhunt
Copy link
Contributor

What is this feature?

Behind the nestedFolders feature flag, promotes the new Browse Dashboards UI for Nested Folders to the existing /dashboards URL (previously it was temporarily at /nested-dashboards)

Why do we need this feature?

New Browse Dashboards UI is built to better browse the new nested folder structure. While the new UI isn't totally finished, it's now stable enough for more testing.

Who is this feature for?

Everyone :)

Which issue(s) does this PR fix?:

Part of #65604

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@joshhunt joshhunt added add to changelog no-backport Skip backport of PR labels Apr 27, 2023
@joshhunt joshhunt added this to the 10.0.x milestone Apr 27, 2023
@joshhunt joshhunt requested review from a team as code owners April 27, 2023 16:14
@joshhunt joshhunt requested review from eledobleefe, JoaoSilvaGrafana, zserge, suntala and yangkb09 and removed request for a team April 27, 2023 16:14
@joshhunt joshhunt added backport v10.0.x and removed no-backport Skip backport of PR labels May 2, 2023
@grafanabot

This comment was marked as resolved.

Sign in to view
@joshhunt joshhunt added product-approved Pull requests that are approved by product/managers and are allowed to be backported and removed missing-labels labels May 2, 2023
@joshhunt joshhunt enabled auto-merge (squash) May 2, 2023 15:42
ashharrison90
ashharrison90 approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scary 😟

@joshhunt joshhunt merged commit c4a3139 into main May 2, 2023
29 checks passed
@joshhunt joshhunt deleted the joshhunt/promote-new-browse branch May 2, 2023 16:25
@grafanabot grafanabot mentioned this pull request May 2, 2023
Merged
grafanabot pushed a commit that referenced this pull request May 2, 2023
@joshhunt @grafanabot
NestedFolders: Use new Browse Dashboards UI behind feature flag (#67416)
428f869 
NestedFolders: Put feature flagged new Browse Dashboards UI at main route
(cherry picked from commit c4a3139)
ashharrison90 pushed a commit that referenced this pull request May 2, 2023
@grafanabot @joshhunt
[v10.0.x] NestedFolders: Use new Browse Dashboards UI behind feature …
b0f5b6c 
…flag (#67676)

NestedFolders: Use new Browse Dashboards UI behind feature flag (#67416)

NestedFolders: Put feature flagged new Browse Dashboards UI at main route
(cherry picked from commit c4a3139)

Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
@zerok zerok modified the milestones: 10.0.x, 10.0.0-preview May 31, 2023
@zerok zerok modified the milestones: 10.0.0-preview, 10.1.x May 31, 2023
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashharrison90 ashharrison90 ashharrison90 approved these changes

@eledobleefe eledobleefe Awaiting requested review from eledobleefe eledobleefe is a code owner automatically assigned from grafana/grafana-frontend-platform

@JoaoSilvaGrafana JoaoSilvaGrafana Awaiting requested review from JoaoSilvaGrafana JoaoSilvaGrafana is a code owner automatically assigned from grafana/grafana-frontend-platform

@zserge zserge Awaiting requested review from zserge zserge was automatically assigned from grafana/backend-platform

@suntala suntala Awaiting requested review from suntala suntala was automatically assigned from grafana/backend-platform

@yangkb09 yangkb09 Awaiting requested review from yangkb09 yangkb09 was automatically assigned from grafana/backend-platform

Assignees
No one assigned
Labels
add to changelog area/backend area/frontend backport v10.0.x product-approved Pull requests that are approved by product/managers and are allowed to be backported
Projects
Grafana Frontend Platform
Archived in project
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@joshhunt @grafanabot @ashharrison90 @zerok @ricky-undeadcoders