Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolkit: Remove deprecated plugin:github-publish command #67471

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

academo
Copy link
Member

@academo academo commented Apr 28, 2023

What is this feature?

Removes deprecated plugin commands from toolkit

Why do we need this feature?

We are moving away all plugin-related commands from toolkit. The removed commands had been deprecated for a while now and no replacement commands will be provided.

Who is this feature for?

All developers of grafana plugins

Which issue(s) does this PR fix?:

Related to #55997

Closes #67472

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

Release notice breaking change

The deprecated plugin:github-publish command in the Grafana Toolkit have been removed in this release.

@academo academo marked this pull request as ready for review April 28, 2023 07:41
@academo academo requested review from grafanabot and a team as code owners April 28, 2023 07:41
@academo academo requested review from gabor, leventebalogh and jackw and removed request for a team April 28, 2023 07:41
@academo academo self-assigned this Apr 28, 2023
@academo academo added this to the 10.0.0 milestone Apr 28, 2023
@academo academo added add to changelog breaking change Relevant for changelog generation no-backport Skip backport of PR labels Apr 28, 2023
Copy link
Contributor

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@academo academo merged commit 82838a2 into main Apr 28, 2023
@academo academo deleted the academo/remove-toolkit-git-release branch April 28, 2023 07:54
@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

Toolkit: Remove plugin:github-publish command
4 participants